Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add schedule scaling possibility #74

Closed
wants to merge 7 commits into from

Conversation

mfroembgen
Copy link

@mfroembgen mfroembgen commented Jul 28, 2023

Description

Additionally, it would be nice to use schedule scaling for ddb tables. (https://docs.aws.amazon.com/autoscaling/application/userguide/get-started-exercise.html)
If you want to save cost with PROVISIONED but have for example an import job that needs a lot of capacity it's the only option to not run into scaling issues.

Motivation and Context

If you want to save cost with PROVISIONED but have for example an import job that needs a lot of capacity it's the only option to not run into scaling issues.

Breaking Changes

No, as it is only an additional option.

Draft

This is just a draft of how It could be implemented. I'm open to superior solutions as I know its kinda bad practice.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@mfroembgen mfroembgen changed the title feat: add schedule scaling possibility feat: Add schedule scaling possibility Jul 28, 2023
@mfroembgen mfroembgen mentioned this pull request Jul 28, 2023
@mfroembgen
Copy link
Author

@antonbabenko Do you maybe have time to share your opinions on that, please?

schedulescaling.tf Outdated Show resolved Hide resolved
schedulescaling.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@mfroembgen
Copy link
Author

@antonbabenko Can you maybe have another look at it, please? Please let me know what you think 🙂

@mfroembgen
Copy link
Author

@antonbabenko Just a friendly reminder that I'm still looking for another review :)

Copy link

github-actions bot commented Dec 7, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 7, 2023
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Dec 17, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants