Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add deletion_protection_enabled #70

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Mar 18, 2023

Description

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v4.59.0

Motivation and Context

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@adam-prohack
Copy link

Could we change "deletion_protection_enable" to simple "deletion_protection"?

examples/basic/main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@bryantbiggs
Copy link
Member

Could we change "deletion_protection_enable" to simple "deletion_protection"?
@adam-prohack that is the correct argument name per the provider

@adam-prohack
Copy link

Yes, but the convention would be more like, for example, RDS. But that's just a small detail, and all in all, let's keep it the same as in provider

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit bce94be into terraform-aws-modules:master Mar 21, 2023
antonbabenko pushed a commit that referenced this pull request Mar 21, 2023
## [3.2.0](v3.1.2...v3.2.0) (2023-03-21)

### Features

* Add `deletion_protection_enabled` ([#70](#70)) ([bce94be](bce94be))
@antonbabenko
Copy link
Member

This PR is included in version 3.2.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Delete Protection Flag configuration
4 participants