Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace local-exec sleep with time_sleep #22

Merged
merged 4 commits into from
Jul 25, 2022
Merged

fix: Replace local-exec sleep with time_sleep #22

merged 4 commits into from
Jul 25, 2022

Conversation

tzfromaz
Copy link
Contributor

@tzfromaz tzfromaz commented Jul 15, 2022 •
edited
Loading

Description

Replace local-exec sleep with time_sleep to wait for dependency resources to get created and destroyed properly.

Motivation and Context

As per: hashicorp/terraform-provider-aws#11025 (comment), using local-exec sleep was a temporary fix, time_sleep is more suited for specifically managing cross-platform compatibility and destroy-time issues.

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

CC: @antonbabenko

@tzfromaz tzfromaz changed the title Replace local-exec sleep with time_sleep fix: Replace local-exec sleep with time_sleep Jul 15, 2022
@tzfromaz
Copy link
Contributor Author

Does anyone know how I can fix the MAX TF pre-commit hook: https://github.com/terraform-aws-modules/terraform-aws-dms/runs/7408469458?check_suite_focus=true? I am not sure what I need to change to pass this check.

@bryantbiggs
Copy link
Member

you'll need to add the time provider to the required providers block and then run pre-commit run -a and fix all the checks to pass

@tzfromaz
Copy link
Contributor Author

Do you know when this will be reviewed by? @bryantbiggs

bryantbiggs
bryantbiggs approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tzfromaz for the contribution!

@bryantbiggs bryantbiggs merged commit b4ace3b into terraform-aws-modules:master Jul 25, 2022
antonbabenko pushed a commit that referenced this pull request Jul 25, 2022
@semantic-release-bot
chore(release): version 1.5.3 [skip ci]
baa10d1 
### [1.5.3](v1.5.2...v1.5.3) (2022-07-25)

### Bug Fixes

* Replace local-exec sleep with time_sleep ([#22](#22)) ([b4ace3b](b4ace3b))
@antonbabenko
Copy link
Member

This PR is included in version 1.5.3 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzfromaz @bryantbiggs @antonbabenko