Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chord: update rust optimizer #17

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

emidev98
Copy link
Contributor

@emidev98 emidev98 commented Apr 7, 2022

This PR fix the build process for npx terrain deploy counter --signer validator due breaking changes related the cosmwasm/rust-optimizer:0.12.3 using cargo 1.55 with the following error log:

Building contract in /code ...
 Downloading crates ...
error: failed to download `uint v0.9.3`

Caused by:
  unable to get packages from source

Caused by:
  failed to parse manifest at `/usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/uint-0.9.3/Cargo.toml`

Caused by:
  feature `edition2021` is required
The solution is to check the docker image rust-optimizer:0.12.3 (validate that cargo version is 1.55) and upgrade to the [new proposed image has the correct version 1.58.1](https://hub.docker.com/layers/rust-optimizer/cosmwasm/rust-optimizer/0.12.5/images/sha256-c0b7f1e79b3fc82bb49cc6330d804fddfc6c5adc43e83b57acea512318fddda4?context=explore). So in this case I upgraded CosmWasm/rust-optimizer from 0.16 to [1.0-beta6](https://github.com/InterWasm/cw-template/compare/v0.6.0...1.0-beta6#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R39) where the lib is already upgraded.

Instead of executing the cargo run-script optimize we execute the direct command updating rust-optimizer from 0.12.3 to 0.12.5

@emidev98 emidev98 requested review from octalmage, terran6 and rtviii April 7, 2022 12:05
Copy link
Contributor

@octalmage octalmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sick! Thanks man.

@emidev98 emidev98 merged commit 8d0cf0e into main Apr 7, 2022
@emidev98 emidev98 deleted the chord_update-rust-optimizer branch April 8, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants