Fix indexing bug #76
Merged
Fix indexing bug #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vritra4
approved these changes
May 11, 2022
csanti
approved these changes
May 11, 2022
yun-yeo
approved these changes
May 11, 2022
|
is there a plan to push this fix to upstream? |
creachadair
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jun 30, 2022
Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess [email protected] ref: #5281
yihuang
added a commit
to yihuang/tendermint
that referenced
this pull request
Jul 6, 2022
…tendermint#8625) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess [email protected] ref: tendermint#5281
tychoish
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jul 6, 2022
…#8625) (#8945) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess [email protected] ref: #5281 Co-authored-by: M. J. Fromberger <[email protected]>
mergify bot
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jul 6, 2022
…#8625) (#8945) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess [email protected] ref: #5281 Co-authored-by: M. J. Fromberger <[email protected]> (cherry picked from commit be6d74e) # Conflicts: # CHANGELOG_PENDING.md # internal/state/indexer/indexer_service.go
mergify bot
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jul 6, 2022
…#8625) (#8945) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess [email protected] ref: #5281 Co-authored-by: M. J. Fromberger <[email protected]> (cherry picked from commit be6d74e)
tychoish
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jul 6, 2022
…#8625) (#8945) (#8951) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess [email protected] ref: #5281 Co-authored-by: M. J. Fromberger <[email protected]> (cherry picked from commit be6d74e) Co-authored-by: yihuang <[email protected]>
inon-man
added a commit
to classic-terra/tendermint
that referenced
this pull request
Feb 28, 2023
(cherry-picked from terra-money#76)
javiersuweijie
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Bugfixes in range queries and result deduplication * Refactored code to clean up cases where height conditions are the only ones existing; fixed tests Co-authored-by: Thane Thomson <[email protected]> * Append match.events=0 if RPC flag is missing Co-authored-by: Sergio Mena <[email protected]> Big thanks to @sergio-mena for the extra UTs and @thanethomson for the discussions related to this. --------- Co-authored-by: Thane Thomson <[email protected]> Co-authored-by: Sergio Mena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the problem of overwriting the txhash index of successful transactions with failed transactions in later blocks. In such case, txhash query will return failed transaction.
Example case:
https://lcd.terra.dev/cosmos/tx/v1beta1/txs/6053BE407FFBCAC836AA94C6D7A7A81C7655A138D112C3DD2F46496FCB98FBE4
The above tx was indexed at height 7573592. However, we have a successful transaction with the same txhash.
https://check-tx.vercel.app/api/check-tx?height=7571561&txhash=6053BE407FFBCAC836AA94C6D7A7A81C7655A138D112C3DD2F46496FCB98FBE4