Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wait for same query's cache #8

Merged
merged 3 commits into from
Dec 1, 2021
Merged

feat: wait for same query's cache #8

merged 3 commits into from
Dec 1, 2021

Conversation

jeffwoooo
Copy link

@jeffwoooo jeffwoooo commented Nov 29, 2021 •
edited
Loading

  • query wait for cache if same URI is processing and about to set cache
  • prevent processing same URI query multiple time

It has been tested in commit d4040ba in branch feat/better-cache-test.
(by executing cache_test.sh while mantlemint is running.)

@jeffwoooo jeffwoooo changed the base branch from main to feat/concurrent-archival-query November 30, 2021 06:17
@jeffwoooo jeffwoooo changed the title [WIP] wait for same query's cache wait for same query's cache Nov 30, 2021
@jeffwoooo jeffwoooo changed the title wait for same query's cache feat: wait for same query's cache Nov 30, 2021
@jeffwoooo jeffwoooo changed the base branch from feat/concurrent-archival-query to main November 30, 2021 06:32
@jeffwoooo jeffwoooo changed the base branch from main to feat/concurrent-archival-query November 30, 2021 06:32
@jeffwoooo jeffwoooo merged commit 87b6c91 into feat/concurrent-archival-query Dec 1, 2021
@jeffwoooo jeffwoooo deleted the feat/better-cache branch December 1, 2021 06:57
jeffwoooo pushed a commit that referenced this pull request Dec 1, 2021
@kjessec
feat: fork tendermint client creator to NOT use mutex (#6)
a595edc 
* feat: fork tendermint client creator to NOT use mutex

* fix: panic on initialize

* fix: panic on sync

* feat: wait for same query's cache  (#8)

* wip

* feat: subscribe for cache channel

* test: test cache module

Co-authored-by: Jesse Chung <[email protected]>

Co-authored-by: Jeff Woo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjessec kjessec Awaiting requested review from kjessec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffwoooo @kjessec