Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix donate to check delegation & unbonding & redelegation entries not… #141

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

yun-yeo
Copy link

@yun-yeo yun-yeo commented Oct 31, 2022

Description

Fix vesting coin donation function to check following data not DelegatedVesting amount

  • Delegation
  • Unbonding
  • Relegation

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yun-yeo yun-yeo requested review from Jared-TFL and a user November 10, 2022 06:20
@yun-yeo yun-yeo closed this Nov 10, 2022
@yun-yeo yun-yeo reopened this Nov 10, 2022
@yun-yeo yun-yeo merged commit 5bce8c4 into release/v0.45.x Nov 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #141 (100a5e0) into release/v0.45.x (0dd29f4) will decrease coverage by 0.22%.
The diff coverage is 41.65%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.45.x     #141      +/-   ##
===================================================
- Coverage            60.60%   60.38%   -0.23%     
===================================================
  Files                  595      599       +4     
  Lines                38660    39053     +393     
===================================================
+ Hits                 23429    23581     +152     
- Misses               13269    13489     +220     
- Partials              1962     1983      +21     
Impacted Files Coverage Δ
baseapp/msg_service_router.go 75.92% <0.00%> (-9.50%) ⬇️
baseapp/options.go 62.33% <0.00%> (-2.53%) ⬇️
client/grpc/tmservice/service.go 71.15% <ø> (ø)
client/keys/add.go 70.34% <ø> (ø)
client/tx/legacy.go 64.28% <ø> (ø)
codec/amino_codec.go 100.00% <ø> (ø)
codec/proto_codec.go 73.41% <ø> (ø)
codec/types/any.go 55.88% <ø> (ø)
crypto/armor.go 85.89% <ø> (ø)
crypto/hd/algo.go 0.00% <0.00%> (ø)
... and 209 more

@yun-yeo yun-yeo deleted the feature/fix-donate branch November 10, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants