Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom bank hooks #201

Merged
merged 6 commits into from
Nov 2, 2023
Merged

feat: custom bank hooks #201

merged 6 commits into from
Nov 2, 2023

Conversation

emidev98
Copy link
Contributor

Seems like some BlockBeforeSend and TrackBeforeSend hooks were missing from the Bank Module in cases like UndelegateCoins, DelegateCoins and InputOutputCoins.

InputOutputCoins have a great execution complexity, but there is no other way to run throught this.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #201 (8fb9783) into release/v2.7 (2a8cfb0) will decrease coverage by 0.10%.
Report is 1 commits behind head on release/v2.7.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v2.7     #201      +/-   ##
================================================
- Coverage         70.53%   70.43%   -0.10%     
================================================
  Files                43       43              
  Lines              2525     2493      -32     
================================================
- Hits               1781     1756      -25     
+ Misses              588      583       -5     
+ Partials            156      154       -2     

see 3 files with indirect coverage changes

Copy link
Member

@javiersuweijie javiersuweijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to discuss if we still want to support multi-send when dealing with block and track hooks.

@emidev98 emidev98 changed the base branch from release/v2.6 to release/v2.7 November 1, 2023 07:08
@tuky191 tuky191 merged commit 7fd040f into release/v2.7 Nov 2, 2023
9 checks passed
@emidev98 emidev98 deleted the feat/ibc/hooks branch November 2, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants