-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feeshare module #182
Conversation
77aafb9
to
9ec2d55
Compare
9ec2d55
to
2e08cd8
Compare
Codecov Report
@@ Coverage Diff @@
## release/v2.6 #182 +/- ##
===============================================
Coverage ? 68.08%
===============================================
Files ? 43
Lines ? 2309
Branches ? 0
===============================================
Hits ? 1572
Misses ? 584
Partials ? 153 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add e2e for this or it is pretty straight forward?
@javiersuweijie there are Integration tests for the Query Keeper and MsgServer. At somepoint I want to migrate the E2E to TypeScript since it will be more readable and easier to manage that' why I havent written any |
Implementation of the feeshare module based on Juno's feeshare