Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feeshare module #182

Merged
merged 7 commits into from
Oct 16, 2023
Merged

feat: feeshare module #182

merged 7 commits into from
Oct 16, 2023

Conversation

emidev98
Copy link
Contributor

Implementation of the feeshare module based on Juno's feeshare

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.6@64783d3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release/v2.6     #182   +/-   ##
===============================================
  Coverage                ?   68.08%           
===============================================
  Files                   ?       43           
  Lines                   ?     2309           
  Branches                ?        0           
===============================================
  Hits                    ?     1572           
  Misses                  ?      584           
  Partials                ?      153           

@emidev98 emidev98 marked this pull request as ready for review October 12, 2023 12:29
@emidev98 emidev98 mentioned this pull request Oct 13, 2023
Copy link
Member

@javiersuweijie javiersuweijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add e2e for this or it is pretty straight forward?

@emidev98
Copy link
Contributor Author

@javiersuweijie there are Integration tests for the Query Keeper and MsgServer.

At somepoint I want to migrate the E2E to TypeScript since it will be more readable and easier to manage that' why I havent written any

@tuky191 tuky191 self-requested a review October 16, 2023 13:21
@tuky191 tuky191 merged commit e5aaaf9 into release/v2.6 Oct 16, 2023
9 checks passed
@emidev98 emidev98 deleted the feat/feeshare branch October 16, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants