Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ibc-hooks callback not triggering wasm callback #141

Merged
merged 1 commit into from
May 29, 2023

Conversation

javiersuweijie
Copy link
Member

IBC hooks wasn't triggering callbacks even when memo was set with the contract address. The issue was due to a misconfiguration of the transfer module not given the ICS4_middleware with IBC hooks included.

Also fixed another bug in which memo did not excluded the key ibc_callback for backwards compatibility.

@javiersuweijie javiersuweijie added bug Something isn't working breaking changes Consensus breaking labels May 25, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@javiersuweijie javiersuweijie force-pushed the fix/ibc-hooks-callback branch from 35abce4 to 1911657 Compare May 25, 2023 10:33
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #141 (1911657) into release/v2.4 (792dcd3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release/v2.4     #141   +/-   ##
=============================================
  Coverage         78.15%   78.15%           
=============================================
  Files                 4        4           
  Lines               705      705           
=============================================
  Hits                551      551           
  Misses              140      140           
  Partials             14       14           
Impacted Files Coverage Δ
app/app.go 86.10% <100.00%> (ø)

@faddat
Copy link
Contributor

faddat commented May 28, 2023

Do you know if these changes match similar changes from Osmosis, so that there will be compatibility?

@gregnuj gregnuj merged commit 72b2801 into release/v2.4 May 29, 2023
@emidev98 emidev98 deleted the fix/ibc-hooks-callback branch May 30, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Consensus breaking bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants