fix: alliance amino signatures #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 78.03% 78.03%
=======================================
Files 4 4
Lines 701 701
=======================================
Hits 547 547
Misses 140 140
Partials 14 14 |
|
Yes, it will require a software upgrade but it still need to be reviewed |
javiersuweijie
previously approved these changes
May 11, 2023
|
@gregnuj should this PR be merged into the |
go.mod
Outdated
| github.com/tendermint/tendermint v0.34.27 | ||
| github.com/tendermint/tm-db v0.6.8-0.20221109095132-774cdfe7e6b0 | ||
| github.com/terra-money/alliance v0.1.0-beta1 | ||
| github.com/terra-money/alliance v0.1.1-rc.0 |
There was a problem hiding this comment.
Can we update to use [v0.1.1](https://github.com/terra-money/alliance/releases/tag/v0.1.1)
gregnuj
approved these changes
May 16, 2023
|
merge to main.... will be release 2.4 since it breaks consensus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the following changes from alliance module terra-money/alliance#173.