feat: Burn Tax via utilization of existing Stability Tax code #784
Conversation
| // At this point we have already run the DeductFees AnteHandler and taken the fees from the sending account | ||
| // Now we remove the taxes from the gas reward and immediately burn it | ||
|
|
||
| if !simulate { |
There was a problem hiding this comment.
you don't seem to have any test with simulate=true, wonder what happens in this case?
There was a problem hiding this comment.
if the tx is simulated, it does not perform the fee module to burn module transfer for the tax and just moves to the next AnteHandler. Do you believe there should be a simulate case? Thanks!
There was a problem hiding this comment.
OK didn't know that, no sense to add a test in this case then!
There was a problem hiding this comment.
@simcheolhwan can you please merge this PR
edk208
dismissed stale reviews from jhcpeixoto, joaopereira7717, MustafaTanguner, and fbelugou
via
9b536c6
|
Approve PR please 🙏 |
|
Note: This PR is submitted as part of Terra v1 governance proposal 4159 (https://station.terra.money/proposal/4159) which has passed. To read about the prior reviews and testing done, please see (Description of discussion):
Please comment back, or reach out to @edk208 for any further action items that would be required to meet internal build procedure requirements. Beyond @edk208 , please communicate any further concerns to @vegasmorph . Thank you for your consideration, and I hope you have a wonderful day today :) |
|
Thank you so much @YunSuk-Yeo for all you, and TFL, have done. I really appreciate it. It felt great to have a restored governance, and to be able to stake again :) |
Summary of changes
Implementation of a tax and burn on luna re-using the stability tax code
Creation of a new burn antehandler that immediately transfers the amount to the treasury burn module
Adjustments to allow luna to be taxed
Report of required housekeeping
(FOR ADMIN) Before merging