Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] change write-vm-memory-cache-size default config replace location #576

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Oct 11, 2021

Summary of changes

close #575

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added bug Something isn't working daemon daemon updates labels Oct 11, 2021
@yun-yeo yun-yeo self-assigned this Oct 11, 2021
@yun-yeo yun-yeo requested a review from hanjukim October 11, 2021 02:32
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #576 (b411b06) into main (5bca395) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   44.75%   44.78%   +0.02%     
==========================================
  Files         121      121              
  Lines        6998     6998              
==========================================
+ Hits         3132     3134       +2     
+ Misses       3620     3619       -1     
+ Partials      246      245       -1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 81.30% <0.00%> (ø)
x/oracle/tally.go 91.89% <0.00%> (+5.40%) ⬆️

@yun-yeo yun-yeo changed the title [bugfix] change wasm-vm-memory-cache-size default config replace location [bugfix] change write-vm-memory-cache-size default config replace location Oct 11, 2021
@yun-yeo yun-yeo merged commit 884d1f3 into main Oct 11, 2021
@yun-yeo yun-yeo deleted the bugfix/set-default-wasm-config branch October 11, 2021 03:13
octalmage pushed a commit to octalmage/core that referenced this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working daemon daemon updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] wasm default config is not properly set
2 participants