Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to use amino multisig pubkey at migration #560

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Sep 23, 2021

Summary of changes

fix #562

Use custom LegacyAminoPubkey for multisig account pub key.

To softly upgrade bombay-11 network, we add upgrade handler for pain name multisig-pubkey-migration. The handler will be automatically added at BeginBlocker of plan height to allow pre-upgrade.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Sep 23, 2021
@yun-yeo yun-yeo added bug Something isn't working devtools devtool related update labels Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #560 (2c44cb2) into main (77caae9) will decrease coverage by 0.34%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   44.88%   44.54%   -0.35%     
==========================================
  Files         118      120       +2     
  Lines        6829     6924      +95     
==========================================
+ Hits         3065     3084      +19     
- Misses       3527     3601      +74     
- Partials      237      239       +2     
Impacted Files Coverage Δ
app/app.go 0.65% <0.00%> (-0.02%) ⬇️
custom/auth/legacy/v040/store.go 0.00% <0.00%> (ø)
custom/auth/legacy/v040/migrate.go 23.75% <66.66%> (ø)

hanjukim
hanjukim previously approved these changes Sep 24, 2021
@yun-yeo yun-yeo merged commit 4f37d36 into main Sep 24, 2021
@yun-yeo yun-yeo deleted the bugfix/multisig-pubkey-migration branch September 24, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devtools devtool related update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] multisig PubKey bombay-11 migration return empty sub-PubKeys
2 participants