Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #457

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Changelog #457

merged 4 commits into from
Mar 18, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 3, 2021

Summary of changes

Changelog updates

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Mar 3, 2021
@yun-yeo yun-yeo marked this pull request as draft March 3, 2021 04:46
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #457 (158a034) into master (8dd3b35) will increase coverage by 1.12%.
The diff coverage is 66.85%.

❗ Current head 158a034 differs from pull request most recent head 9d77e5b. Consider uploading reports for the commit 9d77e5b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   66.19%   67.31%   +1.12%     
==========================================
  Files         116      118       +2     
  Lines        5887     5113     -774     
==========================================
- Hits         3897     3442     -455     
+ Misses       1771     1451     -320     
- Partials      219      220       +1     
Impacted Files Coverage Δ
x/market/handler.go 79.31% <ø> (-1.65%) ⬇️
x/market/internal/keeper/swap.go 72.41% <0.00%> (-4.60%) ⬇️
x/oracle/internal/keeper/querier.go 65.34% <0.00%> (-2.75%) ⬇️
x/oracle/test_utils.go 100.00% <ø> (ø)
x/treasury/internal/types/keys.go 0.00% <ø> (ø)
x/treasury/internal/types/querier.go 0.00% <ø> (ø)
x/wasm/abci.go 0.00% <0.00%> (ø)
x/wasm/internal/keeper/api.go 73.91% <0.00%> (-10.71%) ⬇️
x/wasm/internal/types/query_binding.go 0.00% <0.00%> (ø)
x/wasm/module.go 15.78% <0.00%> (+2.23%) ⬆️
... and 137 more

@yun-yeo yun-yeo mentioned this pull request Mar 18, 2021
8 tasks
@hanjukim hanjukim self-requested a review March 18, 2021 10:25
@yun-yeo yun-yeo marked this pull request as ready for review March 18, 2021 10:31
@yun-yeo yun-yeo merged commit 8545958 into master Mar 18, 2021
@yun-yeo yun-yeo deleted the changelog branch March 18, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants