Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] v0.4.2 #446

Merged
merged 9 commits into from
Feb 16, 2021
Merged

[Release] v0.4.2 #446

merged 9 commits into from
Feb 16, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Feb 16, 2021 •
edited by dokwon
Loading

Summary of changes

Two hot fixes

Improvement

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

alessio and others added 7 commits December 1, 2020 14:26
@alessio
upgrade to Cosmos SDK v0.39.2 (#430)
381d5ac 
* upgrade to Cosmos SDK v0.39.2-rc1

* update to cosmos-sdk v0.39.2 RC2

* update to rc3

* update to v0.39.2
[Bugfix] Register wasm query failed error to sdkerrors (#436)
9885acf 
* register wasm query failed error code
* fix description for querier
@yun-yeo @hanjukim
fix treasury indicators querier
50b22b3
[Feature] append blocking conditions for /txs query with --public…
32a5c53 
… flag on LCD (#437)

* block querying genesis txs from public node
* update txs query blocking condition for public node
@yun-yeo @hanjukim
hotfix memory leak in go-cosmwasm iterator
0d928e4
@hanjukim
Implement tax caps querier for all whitelisted denoms (#442)
2ddf402 
* add tax_caps querier
* add client interface & swagger update

Co-authored-by: Paul Kim <[email protected]>
[Hotfix] treasury empty epoch data (#445)
01571de 
* prevent division by zero, even though no epoch data is stored

* add test case for empty epoch data
@codecov
Copy link

codecov bot commented Feb 16, 2021 •
edited
Loading

Codecov Report

Merging #446 (01571de) into master (ee1cd6e) will increase coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   67.27%   67.29%   +0.01%     
==========================================
  Files         118      118              
  Lines        5094     5109      +15     
==========================================
+ Hits         3427     3438      +11     
- Misses       1449     1451       +2     
- Partials      218      220       +2
Impacted Files Coverage Δ
x/treasury/internal/types/querier.go 0.00% <ø> (ø)
x/treasury/internal/keeper/querier.go 78.02% <86.66%> (+1.70%) ⬆️
x/treasury/internal/keeper/keeper.go 96.50% <100.00%> (ø)
x/wasm/internal/keeper/contract.go 75.87% <100.00%> (ø)
x/oracle/tally.go 88.37% <0.00%> (-4.66%) ⬇️

@yun-yeo yun-yeo requested a review from dokwon February 16, 2021 06:28
dokwon
dokwon suggested changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment and function name changes

x/treasury/internal/keeper/keeper.go Outdated Show resolved Hide resolved
x/treasury/internal/keeper/keeper.go Outdated Show resolved Hide resolved
x/treasury/internal/keeper/querier.go Outdated Show resolved Hide resolved
x/treasury/internal/keeper/querier.go Outdated Show resolved Hide resolved
@yun-yeo yun-yeo mentioned this pull request Feb 16, 2021
Closed
8 tasks
@yun-yeo
Copy link
Contributor Author

yun-yeo commented Feb 16, 2021

All things are updated now @dokwon

@yun-yeo yun-yeo requested a review from dokwon February 16, 2021 07:05
dokwon
dokwon approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/treasury/internal/keeper/indicator.go Show resolved Hide resolved
@yun-yeo yun-yeo merged commit 61d385a into master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokwon dokwon dokwon approved these changes

@hanjukim hanjukim Awaiting requested review from hanjukim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yun-yeo @dokwon @alessio