Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.3 #188

Merged
merged 3 commits into from
Jun 22, 2019
Merged

v0.2.3 #188

merged 3 commits into from
Jun 22, 2019

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jun 22, 2019

** Summary of changes **

0.2.3

  • #187: Change all time instance timezone to UTC to remove gap in time calculation

Changes

#187 Bugfix/fix-time-zone

In update_230000.go, we change genesis time derivation from

genesisTime := time.Unix(genesisUnixTime, 0)

to

genesisTime := time.Unix(genesisUnixTime, 0).UTC()

** Report of required housekeeping **

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

======

** (FOR ADMIN) Before merging **

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from dokwon June 22, 2019 01:20
@dokwon dokwon added the urgent Hotfix needed label Jun 22, 2019
@yun-yeo yun-yeo added bug Something isn't working daemon daemon updates must Mustfix for target release. test Testing and removed urgent Hotfix needed labels Jun 22, 2019
@yun-yeo yun-yeo added urgent Hotfix needed and removed bug Something isn't working daemon daemon updates must Mustfix for target release. test Testing labels Jun 22, 2019
@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@10f09c2). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #188   +/-   ##
=========================================
  Coverage          ?   65.32%           
=========================================
  Files             ?       94           
  Lines             ?     5448           
  Branches          ?        0           
=========================================
  Hits              ?     3559           
  Misses            ?     1678           
  Partials          ?      211

@dokwon dokwon merged commit 3162406 into master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Hotfix needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants