Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] store code always return internal error #408

Closed
yun-yeo opened this issue Sep 24, 2020 · 0 comments · Fixed by #417
Closed

[BUG] store code always return internal error #408

yun-yeo opened this issue Sep 24, 2020 · 0 comments · Fixed by #417
Labels
bug Something isn't working

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Sep 24, 2020

Describe the bug
Same issue in wasmd CosmWasm/wasmd#240

Seems like Cosmos SDK overrides any error with code 1 with internal error.
cosmos/cosmos-sdk#6916

https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/errors.md#registration
Must be greater than one, as a code value of one is reserved for internal errors.

To Reproduce
store old version wasm binary

Context & versions
v0.4.0

(if applicable) suggested solution
update all error code bigger than 1
@yun-yeo yun-yeo added the bug Something isn't working label Sep 24, 2020
@yun-yeo yun-yeo mentioned this issue Oct 12, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix] Make all error code bigger than 1 terra-money/classic-core
1 participant
@yun-yeo