Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrCreateFailed always return internal error #240

Closed
toml01 opened this issue Aug 2, 2020 · 2 comments · Fixed by #276
Closed

ErrCreateFailed always return internal error #240

toml01 opened this issue Aug 2, 2020 · 2 comments · Fixed by #276
Assignees
Milestone

Comments

@toml01
Copy link

toml01 commented Aug 2, 2020

https://github.com/CosmWasm/wasmd/blob/master/x/wasm/internal/types/errors.go#L12

Seems like Cosmos SDK overrides any error with code 1 with internal error.
cosmos/cosmos-sdk#6916

A quick fix would be to just change the code for ErrCreateFailed I guess.

@toml01
Copy link
Author

toml01 commented Aug 2, 2020

https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/errors.md#registration

Must be greater than one, as a code value of one is reserved for internal errors.

@ethanfrey ethanfrey added this to the v1.0.0 milestone Aug 19, 2020
@ethanfrey
Copy link
Member

Yes, let us bump all the error codes by one in the next (post 0.10) release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants