-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omnibus #75
Omnibus #75
Conversation
Thanks for the PR @faddat
|
|
d8fc627
to
43c8e85
Compare
Good PR! Some improvements here:
We may also need a command to build the ts-client from the proto files. |
ah, so, interestingly, ignite cli will still work. You can still use the same dev workflow. The key to this PR is that it removes the imports for ignite, but allows you to use the tooling :) In fact, the ignite way is likely much better than the Makefile way for protos Did you have any issues building protos with this new code? Note: you'll want ignite v0.26.1 |
Running with ignite v0.26.1 and |
indeed! Same here. I think I may have patched it. not sure yet |
update: that didn't work docs a bit odd, let's proceed, and thx for the review & & additons! |
This PR:
Description:
This is an omnibus PR (not tightly scoped) aimed at making the repository easier to use over time. Future PR's can be tightly scoped, but this one involved upgrading multiple connected software components.