Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibus #75

Merged
merged 22 commits into from
Jan 31, 2023
Merged

Omnibus #75

merged 22 commits into from
Jan 31, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jan 28, 2023

This PR:

  • ensure there aren't version conflicts
  • ensure that alliance doesn't cause unpatched chains to have issues with the dragon
  • bump cosmos-sdk to v0.46.8
  • bump ibc-go to v6.1.0
  • remove all pieces of ignite so we don't depend on that import
    • cosmoscmd
    • openapiconsole
  • added a real cmd folder

Description:

This is an omnibus PR (not tightly scoped) aimed at making the repository easier to use over time. Future PR's can be tightly scoped, but this one involved upgrading multiple connected software components.

@faddat faddat marked this pull request as ready for review January 28, 2023 12:58
@javiersuweijie
Copy link
Member

Thanks for the PR @faddat
Before merging, we just want to make sure our development workflow is still working. We also need to update Makefile to include everything that we need migrating from ignite cli

  1. Generate go from protobufs
  2. Docs and swagger (Think you fixed this, will need to verify)
  3. Helpers to run a single node localnet

@javiersuweijie
Copy link
Member

  • Generate go from protobufs - make proto-gen
  • Docs and swagger
  • Helpers to run a single node localnet - make serve

@emidev98
Copy link
Contributor

Good PR! Some improvements here:

  • make localnet commands work,
  • delete unnecessary ignite files.

We may also need a command to build the ts-client from the proto files.

@faddat
Copy link
Contributor Author

faddat commented Jan 30, 2023

ah, so, interestingly, ignite cli will still work. You can still use the same dev workflow.

The key to this PR is that it removes the imports for ignite, but allows you to use the tooling :)

In fact, the ignite way is likely much better than the Makefile way for protos

Did you have any issues building protos with this new code?

Note: you'll want ignite v0.26.1

@javiersuweijie javiersuweijie merged commit e9959cf into terra-money:main Jan 31, 2023
@javiersuweijie
Copy link
Member

@faddat

Running with ignite v0.26.1 and ignite g proto-go on the main branch has some weird behavior that downgrades the cosmos-sdk version. It also updates a bunch of other deps in my go.mod.

@faddat
Copy link
Contributor Author

faddat commented Jan 31, 2023

indeed!

Same here. I think I may have patched it.

ignite/cli#3426

not sure yet

@faddat
Copy link
Contributor Author

faddat commented Jan 31, 2023

update: that didn't work

https://github.com/ignite/cli/blob/c23b57e19f0344680862150565aa654f9c73459f/docs/versioned_docs/version-v0.26.1/06-migration/v0.18.md

docs a bit odd, let's proceed, and thx for the review & & additons!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants