Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query special characters #181

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

emidev98
Copy link
Contributor

@emidev98 emidev98 commented May 3, 2023

This pull request modify the QueryServer to allow url encoded values as for denoms to query alliances, that way we do not need special REST APIs for ibc denoms, token factory or other denoms with possible special characters.

⚠️ Includes breaking changes ⚠️ by removing GET:/terra/alliances/ibc/{denom} endpoint to be replaced by e.g.: GET:/terra/alliances/ibc%2Falliance2

Issue #180

@emidev98 emidev98 requested a review from javiersuweijie May 3, 2023 13:51
@emidev98 emidev98 force-pushed the fix/query/special/chars branch 2 times, most recently from a96634d to 25ea446 Compare May 3, 2023 14:26
@javiersuweijie
Copy link
Member

Label the old endpoint ibc/denom as deprecated and we can remove it in the next patch.

@emidev98 emidev98 force-pushed the fix/query/special/chars branch from 25ea446 to 6b9cba0 Compare May 4, 2023 07:18
@emidev98 emidev98 merged commit 3742bab into release/v0.1.x May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants