Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to perform variable substitution on a Boolean setting #27

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

Archenoth
Copy link
Contributor

One of the things that has been set as a variable replace key is com.termux.tasker.extra.TERMINAL, which is a boolean variable. This makes Tasker unhappy, and it yells about it in Logcat like so:

2019-12-02 02:12:13.492 9826-30816/net.dinglisch.android.taskerm E/Tasker: 02.12.13#b#ActionArgBundle: error: Termux: replace specified for null or non-string extra: com.termux.tasker.extra.TERMINAL

This pull request removes it from the list of things that termux-tasker attempts to perform string substitution on.

This makes Tasker unhappy, and it yells about it in Logcat
@fornwall fornwall merged commit 7a330e9 into termux:master Jan 5, 2020
@fornwall
Copy link
Member

fornwall commented Jan 5, 2020

Thanks a lot!

@fornwall
Copy link
Member

fornwall commented Jan 5, 2020

This has been merged and released in version 0.4 of the Termux:Tasker app - great job!

@Archenoth Archenoth deleted the FixBooleanSubstitution branch January 5, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants