-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(main/grafana): 11.0.0 #20489
bump(main/grafana): 11.0.0 #20489
Conversation
I believe type routeInfo struct {
cmds map[string][]string
} should be removed from route_info_android.go. Have a look at hashicorp/go-sockaddr@eeae47b which removed it from all the other route_info_* files. Since this is golang I guess we need to sed it from downloaded dependencies, or open a PR upstream and hope that they are willing to create a new tag somewhat soon (and then patch grafana to use newer go-sockaddr version) |
@Grimler91 Thanks for the hint. That was indeed the issue. I opened a Pull Request hashicorp/go-sockaddr#58, but I am not sure it will get merged. They require me to sign some dumb CLA and I haven't yet decided if I should sign that. In the meantime I added a local patch. Patching a go project on the fly proved to be a bit tricky, let me know if there is a better way to do that. With this it should now build. At least it does locally. I am still trying to figure out why the cloud builds fail. Something about disk space? |
@Grimler91 I tried to get rid of as much stuff as possible without getting silly, but the builders still run out of storage. Locally it works fine and only uses about 2 GB of storage, which doesn't seem that big. Is this really an issue with my build or is there some infrastructure issue? |
5756274
to
e048170
Compare
Seems to just be for x86_64, maybe that one does something differently. Have tried adding grafana to the list of "big packages" now in any case, let's see if it solves it |
@Grimler91 It was definitely all of them for most of the builds. I think it was just right at the maximum available size. It is possible that x86_64 is slightly larger. Locally the build env seems to be about 100-200 mb bigger. Do packages in big-pkgs.list just build without pulling docker and have therefore a bit more space available? |
It deletes a bunch of pre-installed packages from github build container: https://github.com/termux/termux-packages/blob/master/.github/workflows/packages.yml#L199-L203. Seems like it did the trick in this case, nice! Feel free to re-sign the PR if you are satisfied with tests and I can get this in with signatures and everything :) |
It used obscene amounts of storage and wasn't reused anyway.
We currently run out of space when trying to build for x86_64.
011ebec
to
c5db5fe
Compare
Thanks! |
@Grimler91 Thank you for the help building this. I was a bit rusty. |
No problem, my pleasure. Nice work updating grafana! :) |
Hi,
I am trying to update Grafana to version 11.0.0 as the available version 8.5.27 is quite old. There seem to be quite some changes to the build system, so it isn't as easy as I'd hoped. I think I am close to the build succeeding, but I am stumped by the build errors I am getting. Here's the log:
The errors point to an issue in go-sockaddr. The android specific code doesn't seem to have been kept up to date possibly.
I am however not a hundred percent sure if these are errors or just warnings, with the
exit status 1
being unrelated.I did try to compile for GOOS=linux instead, but this led to this (possibly related) error:
This is the first package I am trying to build in a long time now, so any hints would be appreciated.