-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.118: bump bootstraps to v2024.06.09-r1 #4005
Conversation
And append "+apt-android-7" to download url, as bootstraps these days normally support both >= android-5 and >= android-7.
Running tests from termux/termux-exec#24 succeeds if I remove --ld-preload arg and just install and use libtermux-exec.so from $PREFIX/lib/ instead, that is I apply: diff --git a/Makefile b/Makefile
index afc3d63..cf5769e 100644
--- a/Makefile
+++ b/Makefile
@@ -178,7 +178,7 @@ deb: all
test: all
$(MAKE) TERMUX_EXEC__INSTALL_PREFIX=install install
- tests/termux-exec-tests --ld-preload="install/lib/libtermux-exec.so" --tests-path="install/libexec/installed-tests/termux-exec" -vvv all
+ tests/termux-exec-tests --tests-path="install/libexec/installed-tests/termux-exec" -vvv all
test-unit: all
$(MAKE) TERMUX_EXEC__INSTALL_PREFIX=install install
@@ -186,7 +186,7 @@ test-unit: all
test-runtime: all
$(MAKE) TERMUX_EXEC__INSTALL_PREFIX=install install
- tests/termux-exec-tests --ld-preload="install/lib/libtermux-exec.so" --tests-path="install/libexec/installed-tests/termux-exec" -vvv runtime
+ tests/termux-exec-tests --tests-path="install/libexec/installed-tests/termux-exec" -vvv runtime
haven't tested with termux-api and termux-am, but otherwise all tests succeed on both arm and aarch64 |
Ok to merge and tag a Would be nice to get it out to fix the issue of people being prompted for updating away from F-Droid to Google Play. See also #4012 (comment) - a systematic version code scheme can come later perhaps. |
I think @agnostic-apollo mentioned that it would be good to cherry-pick some additional fixes/improvements from master before tagging a release, for example workflows so that apk's are built and uploaded to the new release |
Workflow is broken in master branch too, I fixed it in my local |
@Grimler91 Found the reason for
Even though the test files path was passed to Another error was that |
Probably it will be a good idea to update release with newest bootstrap with same version but bumped versionCode, without making any new commits to release code. So both f-droid and github releases will have newest bootstrap even if the apk code was not changed. |
Installation and pkg/apt usage, and general use, works fine on both arm and aarch64