Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NS is a reserved prefix for Apple classes #1

Closed
3lvis opened this issue Jul 17, 2015 · 3 comments
Closed

NS is a reserved prefix for Apple classes #1

3lvis opened this issue Jul 17, 2015 · 3 comments

Comments

@3lvis
Copy link

3lvis commented Jul 17, 2015

NS is a reserved prefix for Apple classes, using NS in your own classes is a bad practice. Any plans for fixing this?

CoreValue/CoreValue/CoreValue.swift

Lines 230 to 232 in cd34a93

public typealias NSManagedStruct = protocol<BoxingStruct, UnboxingStruct>
public typealias NSManagedPersistentStruct = protocol<BoxingPersistentStruct, UnboxingStruct>

@terhechte
Copy link
Owner

Oh right. I honestly totally forgot about that when drafting the protocols. Will quickly fix it. Thanks for pointing it out!

@3lvis
Copy link
Author

3lvis commented Jul 17, 2015

❤️

terhechte added a commit that referenced this issue Jul 18, 2015
@terhechte
Renamed NSManagedStruct and NSPersistentManagedStruct to CVManagedStr…
eadebc5 
…uct and CVPersistentManagedStruct as [NS is preserved prefix for Apple classes](#1)
@terhechte
Copy link
Owner

Just released 0.1.2 which fixes this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terhechte @3lvis