This repository has been archived by the owner on Jun 27, 2018. It is now read-only.
supporting inline sourcemaps #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to be merged. You can see sourcemaps work in chrome over here : https://github.com/basarat/sourceMapTest |
|
and
|
|
Really awesome! |
| "compilerOptions": { | ||
| "target": "es5", | ||
| "module": "commonjs", | ||
| "declaration": false, |
There was a problem hiding this comment.
Make "declaration": true and update index.d.ts.
| @@ -77,22 +81,56 @@ var tss; | |||
| return path.dirname(require.resolve('typescript')); | |||
| }; | |||
| TypeScriptSimple.prototype.getDefaultLibFilename = function (options) { | |||
| if (options.target === 2 /* ES6 */) { | |||
| if (options.target === ts.ScriptTarget.ES6) { | |||
There was a problem hiding this comment.
@basarat I think this is better, but my tsc (TypeScript 1.4.2 on Mac) compiles ts.ScriptTarget.ES6 to 2 without asking.
What your compiler option keeps enum expressions?
There was a problem hiding this comment.
What your compiler option keeps enum expressions?
Its a bug in the language service. Constant enums should always be inlined.
I use atom-typescript and that build using the language service (instead of the cli). : https://atom.io/packages/atom-typescript
|
LGTM! thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6
👍 on your code quality. Really simple. Zero dependencies. Really easy to reuse. Comes with tests ❤️
Added a
tsconfig.jsonto make it easier to work on this with any editor.Will be bringing in stuff from https://github.com/thlorenz/convert-source-map
Will leave a comment once this code is ready for merge