This repository has been archived by the owner on Jun 27, 2018. It is now read-only.
Fix TypeError: Cannot read property 'text' of undefined error. #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix
TypeError: Cannot read property 'text' of undefined
error.Detail
When importing
relative path
like following,typescript-simple
raised exception.https://github.com/9renpoto/ts/blob/fix/filename/test/index.test.ts#L1
Actual behavior
service.getEmitOutput(fileName)
returnsrelative path
andabsorute path
.eg.
#: see also power-assert-js/espower-typescript#16 (comment)
/tmp/src/sample/test.ts
/tmp/src/sample/dep.ts
service.getEmitOutput('test.ts')
returnsrelative path
test.js
service.getEmitOutput('dep.ts')
returnsabsolute path
/tmp/src/sample/deps.js
So, this line compared relative path(
outputFileName
) with absolute path(file.name
) and returnsundefined
.Solution
Convert
relative path
toabsolute path
.PoC
Please see our sample project.
note
package.json
'stypescript-simple
pointed to our PR branch.If you delete this line, exception would raised.
Misc
This PR would also solve following issue.
Please check and include this PR.
Thank you.