Add device-specific request validation in LLMEngine and modify request-specific asserts in TTModelRunner to not crash server instances #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #29
_validate_device_inputs
toLLMEngine
for performing device-specific request validation (whereas the existing_validate_model_inputs
and custom input processors can be used for device agnostic or model-specific request validation). Currently only supported for TT models through TTExecutor::validate_seq_groupTTModelRunner
to ValueErrors which are triggered through the invocation of_validate_device_inputs
mentioned above, so that bad requests return 400 errors instead of crashing the server