Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_sw_ver_info() gets version info from Internet even if asked not to show any #7

Open
afaerber opened this issue Sep 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@afaerber
Copy link
Contributor

In system_utils.py the function get_sw_ver_info has an argument show_sw_ver, but it is only checked after looping to obtain the later unused versions from the Internet.

This should probably be reordered so that it returns early:

if not show_sw_ver:
    return sw_ver
version = {}
...
return version

BTW is the TODO "Implement call to server to pull latest SW versions" at the very top a leftover, given the implemented JSON retrieval from the server? Or is that about an improvement thereof, given that Buda and Metallium versions are being overwritten with hardcoded versions?

afaerber added a commit to afaerber/tt-tools-common that referenced this issue Sep 14, 2024
If get_sw_ver_info() argument show_sw_ver is False, there's no need to
obtain version numbers from the Internet to then discard them.

Reorder the argument check to return immediately.

Resolves issue tenstorrent#7.

Signed-off-by: Andreas Färber <[email protected]>
@milank94 milank94 added the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants