You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In system_utils.py the function get_sw_ver_info has an argument show_sw_ver, but it is only checked after looping to obtain the later unused versions from the Internet.
This should probably be reordered so that it returns early:
if not show_sw_ver:
return sw_ver
version = {}
...
return version
BTW is the TODO "Implement call to server to pull latest SW versions" at the very top a leftover, given the implemented JSON retrieval from the server? Or is that about an improvement thereof, given that Buda and Metallium versions are being overwritten with hardcoded versions?
The text was updated successfully, but these errors were encountered:
If get_sw_ver_info() argument show_sw_ver is False, there's no need to
obtain version numbers from the Internet to then discard them.
Reorder the argument check to return immediately.
Resolves issue tenstorrent#7.
Signed-off-by: Andreas Färber <[email protected]>
In
system_utils.py
the functionget_sw_ver_info
has an argumentshow_sw_ver
, but it is only checked after looping to obtain the later unused versions from the Internet.This should probably be reordered so that it returns early:
BTW is the TODO "Implement call to server to pull latest SW versions" at the very top a leftover, given the implemented JSON retrieval from the server? Or is that about an improvement thereof, given that Buda and Metallium versions are being overwritten with hardcoded versions?
The text was updated successfully, but these errors were encountered: