Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_sw_ver_info() misspells TT-Metalium #14

Open
afaerber opened this issue Sep 15, 2024 · 0 comments
Open

get_sw_ver_info() misspells TT-Metalium #14

afaerber opened this issue Sep 15, 2024 · 0 comments
Labels
bug Something isn't working good-first-issue Good for newcomers

Comments

@afaerber
Copy link
Contributor

On the website, in the docs and on GitHub the software component is spelled "TT-Metalium" (one L).

However, both in get_sw_ver_info() and in the JSON data it obtains from cereal.tenstorrent.com the dictionary key is spelled Metallium (two L). The "TT-" prefix is left out for both Metal(l)ium and Buda. This then gets displayed in tt-smi.

afaerber added a commit to afaerber/tt-tools-common that referenced this issue Sep 16, 2024
cereal.tenstorrent.com supplies a JSON dictionary key "Metallium",
for which get_sw_ver_info() overwrites the value.
However, the trademark is spelled "TT-Metalium" (one L).

Adjust the offline dictionary and post-process the online one.
The latter is currently safe to do due to the value update.

For consistency also update "Buda" to "TT-Buda".

The caller tt-smi only displays these keys.

Addresses issue tenstorrent#14 on the client side.

Signed-off-by: Andreas Färber <[email protected]>
@milank94 milank94 added the bug Something isn't working label Oct 30, 2024
@milank94 milank94 added the good-first-issue Good for newcomers label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants