-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime/Compiler - Support ComputeConfig::unpack_to_dest_mode #879 #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmabeeTT
requested review from
jnie-TT,
AleksKnezevic,
pilkicTT,
nsmithtt,
rpavlovicTT,
rjakovljevicTT and
tapspatel
as code owners
October 21, 2024 18:58
AleksKnezevic
approved these changes
Oct 21, 2024
nsmithtt
reviewed
Oct 22, 2024
jnie-TT
reviewed
Oct 22, 2024
jnie-TT
approved these changes
Oct 22, 2024
Cleaned up changes. Had discussion with @nsmithtt offline this morning, decided to:
Made changes for number-1 above already on PR, going to try to see what changes look like for 2,3 (with system-desc hardcoding num_circlular_buffers=32 until metal exports it). |
kmabeeTT
requested review from
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
mrakitaTT,
nobradovictt and
jserbedzijaTT
as code owners
October 22, 2024 20:26
nsmithtt
approved these changes
Oct 22, 2024
kmabeeTT
force-pushed
the
kmabee/issue_879_unpack_to_dest_mode
branch
from
October 23, 2024 13:39
4ec088e
to
671f6ad
Compare
- Most recent tt-metal uplift removed preserve_fp32_precision and replaced with unpack_to_dest_mode vector on ComputeConfig - Export NUM_CIRCULAR_BUFFERS from tt-metal into system-desc's ChipDesc and use it for assert in tt-mlir compiler to ensure compiler/metal view of max number of CB's is aligned. - Pass new enum UnpackToDestMode (per CB) down from compiler to runtime to metal API
kmabeeTT
force-pushed
the
kmabee/issue_879_unpack_to_dest_mode
branch
from
October 28, 2024 16:14
671f6ad
to
0151238
Compare
- Looks like this test is intending to run with custom soc_desc, annoying.
tapspatel
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is blocked on tt-metal uplift. Will rebase + change target to main when tt-metal uplift is merged. For ease of viewing I picked base as my own branch for now on this PR.
Closes #879
Relatively simple change to accommodate API change in tt-metal introduced at tenstorrent/tt-metal#12794
==
About workaround: