-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable remove-dead-values MLIR pass for stablehlo pipeline #926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit otherwise looks good
Btw just curious, can you please post some example StableHLO graph (or resulting TTIR graph) where you've found the sccp optimization useful? |
add55ca
to
c058073
Compare
I found a couple of opportunities in a Llama model where SCCP will be beneficial, so I created a MLIR test from it, but it seems that SCCP pass is not working even for a simple case. We can merge this patch to have a placeholder in case someone is looking into it in future or else can hold it until me or someone else can figure out why SCCP is not working. |
So is it used/working for any case that we have right now? I'd prefer to just do this work before landing this PR unless this PR is blocking something else. We should strive to land it in a working state. |
…lehlo to ttir conversion.
c47e811
to
65db76a
Compare
Enable both remove-dead-values pass by default.