ttrt add support for initialization function + ident check #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nsmithtt
commented
Aug 5, 2024
nsmithtt
commented
- New tensor initialization functions, for certain kinds of tests it's useful to initialize with a range of values vs random. In the future we could add more like uniform distribution.
- Some tests, like for data movement, can be implemented to perform a trivial golden check where the input exactly matches the output. Add an identity flag which does this check.
nsmithtt
requested review from
tapspatel,
jnie-TT,
kmabeeTT and
AleksKnezevic
as code owners
|
@tapspatel, feel free to commandeer this PR if you want to do it another way. I had made these changes locally for a test I'm bringing up, since I had already done the work I figured I'd just post a PR with what I had. |
nsmithtt
force-pushed
the
nsmith/ttrt-ident
branch
from
67a4764 to
94c1853
Compare
- New tensor initialization functions, for certain kinds of tests it's useful to initialize with a range of values vs random. In the future we could add more like uniform distribution. - Some tests, like for data movement, can be implemented to perform a trivial golden check where the input exactly matches the output. Add an identity flag which does this check.
nsmithtt
force-pushed
the
nsmith/ttrt-ident
branch
from
94c1853 to
ffc4160
Compare
|
@tapspatel, are you good with any of this change? |
tapspatel
approved these changes
Aug 8, 2024
|
changes look good! |
nsmithtt
added a commit
that referenced
this pull request
Aug 9, 2024
- New tensor initialization functions, for certain kinds of tests it's useful to initialize with a range of values vs random. In the future we could add more like uniform distribution. - Some tests, like for data movement, can be implemented to perform a trivial golden check where the input exactly matches the output. Add an identity flag which does this check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.