-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent ttlmir-opt/translate from using llvm.so #1525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspiciously no fallout 🧐, we'll take it if it's true! Though I'm not sure the GH action actually tested it.
@vmilosevic, I don't think this triggered a docker rebuild just looking through the GH actions.
Yeah, not sure I trust that either haha. Are there comprehensive manual tests I can run, if there isn't convenient way to force CI to pick up changes? |
The image tag you are looking for (ghcr.io/tenstorrent/tt-mlir/tt-mlir-ci-ubuntu-22-04:dt-dcb58a0a097d08b1e54cc8eb4e48ec854b4217bcefb8ae2f39e3280af6288a7f) was already built by previous run on same branch https://github.com/tenstorrent/tt-mlir/actions/runs/12200962107/job/34038297242
|
Does this mean the CI tests did indeed run on this new env? I've been using this change on my own branch to force ttmlir-translate/opt to not link to .so, so I'm fairly confident that part works--more worried it will also break something that actually needs to link to .so |
I see, OK, then I think we should be safe to land it then. We'll keep a close eye on it. |
Found that both ttmlir-opt and ttmlir-translate are still linking to LLVM dylib, despite DISABLE_LLVM_LINK_LLVM_DYLIB flags in respective CMakeLists.txt. Changing this flag seems to remedy the problem.