Use Proper Locations for Golden IDs #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctodTT
requested review from
tapspatel,
nsmithtt and
vprajapati-tt
as code owners
ctodTT
force-pushed
the
ctod/issue-1300
branch
from
fa3adde to
0cfbe69
Compare
ctodTT
force-pushed
the
ctod/issue-1300
branch
from
0cfbe69 to
a62a2ae
Compare
|
extremely clean and great change Thanks @ctodTT + @vprajapati-tt :) |
tapspatel
approved these changes
Dec 4, 2024
vprajapati-tt
approved these changes
Dec 4, 2024
Comment on lines
-116
to
-124
| # find matching golden tensor based on loc in op debug string | ||
| match = re.search(r"loc\(([^)]+)\)", op_debug_str) | ||
|
|
||
| if not match: | ||
| print(f"debug_str={op_debug_str}") | ||
| print("No location found in debug string - skipping golden comparison") | ||
| return | ||
|
|
||
| loc = match.group(1).replace('"', "") |
ctodTT
added a commit
that referenced
this pull request
Dec 11, 2024
* PyBind `GoldenTensor` w/ Integral Types This change introduces a PyBound class `GoldenTensor` that reflects the same type from TTRT. This binding supports the following element types for a `GoldenTensor`: - uint8 - uint16 - uint32 - float32 Also, this change reverts PR #1488 , as it broke some things unintentionally. This is to be able to address these problems in a separate PR. Closes #1334
azecevicTT
pushed a commit
that referenced
this pull request
Dec 17, 2024
azecevicTT
pushed a commit
that referenced
this pull request
Dec 17, 2024
* PyBind `GoldenTensor` w/ Integral Types This change introduces a PyBound class `GoldenTensor` that reflects the same type from TTRT. This binding supports the following element types for a `GoldenTensor`: - uint8 - uint16 - uint32 - float32 Also, this change reverts PR #1488 , as it broke some things unintentionally. This is to be able to address these problems in a separate PR. Closes #1334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change swaps the UUID for golden tensors from only a monotonically increasing id to a filename and line number as well.
Closes #1300