Uplift third_party/tt-metal to ab3dc0c4f5c3ce9722261c878970bfa92a212fc9 2024-12-02 #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmithtt
approved these changes
Nov 29, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Nov 30, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Dec 1, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Dec 2, 2024
- Create DEVICE_LIBRARY as libdevice.so and link against it everywhere we link against TTMETAL_LIBRARY (libtt_metal.so) - Update UMD include path for headers to include "api" folder in path
kmabeeTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
kmabeeTT
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Feedback from @blozano-tt on linking changes for the future..
Ideally should be linking CMake targets like Metalium::Metal or umd::device
But can be done in future work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uplifts the third_party/tt-metal to the ab3dc0c4f5c3ce9722261c878970bfa92a212fc9