-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround pass - Initial implementation #1402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed up to lib/Dialect/TTNN/Transforms/TTNNWorkarounds.cpp
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, brain's fried, will finish the rest of the lib/Dialect/TTNN/Transforms/TTNNWorkarounds.cpp
tmr.
653d8c8
to
96e5056
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
96e5056
to
8348b0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will review lib/Dialect/TTNN/Transforms/TTNNWorkarounds.cpp
later today.
7db2dd6
to
1d475a9
Compare
65136c7
to
ab9d422
Compare
0049be3
to
2e12e73
Compare
bf4ce73
to
2c0c550
Compare
433fad4
to
e8e5520
Compare
3bc34b7
to
8fb0ca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
8fb0ca6
to
0d9f578
Compare
4dff361
to
a66bc8e
Compare
a66bc8e
to
8a59402
Compare
This PR introduces the initial implementation of a workaround pass in the TTNN dialect. It establishes the foundation for handling operation-specific workarounds by defining interfaces and data structures and includes the initial logic for applying these workarounds. While the logic is disabled by default in this PR, future updates will gradually enable it in the compiler. Below is a summary of the changes:
Closes #1136
Closes #1135