[TTIR] Remove TTIR operand_constraints #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserbedzijaTT
force-pushed
the
jserbedzija/remove_operand_constraints
branch
9 times, most recently
from
60d99b6 to
0f25086
Compare
jserbedzijaTT
force-pushed
the
jserbedzija/remove_operand_constraints
branch
3 times, most recently
from
aeb4de0 to
27962ce
Compare
jserbedzijaTT
requested review from
nobradovictt,
odjuricicTT,
nsmithtt,
tapspatel,
vprajapati-tt,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
jnie-TT,
azecevicTT and
mrakitaTT
as code owners
topke011
reviewed
Dec 11, 2024
topke011
reviewed
Dec 11, 2024
topke011
reviewed
Dec 11, 2024
topke011
reviewed
Dec 11, 2024
topke011
approved these changes
Dec 11, 2024
|
Joco I'm curious did all test passed once you removed all references to operandcontraints from code/tests? |
mtopalovicTT
approved these changes
Dec 11, 2024
I still didn't try to run all silicon tests in local, I was hoping CI will do the job for me. Will try today and make an update. |
jserbedzijaTT
force-pushed
the
jserbedzija/remove_operand_constraints
branch
from
49c17f1 to
afe8dbf
Compare
vprajapati-tt
approved these changes
Dec 11, 2024
nsmithtt
approved these changes
Dec 12, 2024
jserbedzijaTT
force-pushed
the
jserbedzija/remove_operand_constraints
branch
from
afe8dbf to
400b588
Compare
odjuricicTT
approved these changes
Dec 12, 2024
nobradovictt
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
operand_constraintsfrom the TTIR dialect and all associated tests. Until a workaround pass is created, we will need to manually insertto_layoutoperations in cases where the default layout of tensors (tiled, DRAM, interleaved) needs to be changed.I will remove operand_constraints from the generic op in a separate pull request.