Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TTIR Reverse op and stablehlo -> ttir conversion #1346

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

kmitrovicTT
Copy link
Contributor

@kmitrovicTT kmitrovicTT commented Nov 20, 2024

Fixes #1330.
A part of the solution for for #1142 (need to add tt-torch and tt-xla tests in separate PRs) .

Not implemented end to end since this OP should not exists e2e but rather fitted inside transposed conv op.

Copy link
Contributor

@LPanosTT LPanosTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a comment about the verifier for ttir.reverse

include/ttmlir/Dialect/TTIR/IR/TTIROps.td Show resolved Hide resolved
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/stablehlo_reverse_op branch 2 times, most recently from c384c71 to 012512b Compare November 20, 2024 16:02
@kmitrovicTT kmitrovicTT self-assigned this Nov 27, 2024
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/stablehlo_reverse_op branch from 9d082ee to dade87c Compare December 11, 2024 18:31
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/stablehlo_reverse_op branch 2 times, most recently from 6fd8c46 to 4afadf1 Compare December 11, 2024 18:38
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/stablehlo_reverse_op branch from 4afadf1 to 12741bf Compare December 19, 2024 09:17
@kmitrovicTT kmitrovicTT enabled auto-merge (squash) December 19, 2024 09:18
@kmitrovicTT kmitrovicTT disabled auto-merge December 19, 2024 09:19
@kmitrovicTT kmitrovicTT enabled auto-merge (squash) December 19, 2024 09:20
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/stablehlo_reverse_op branch 2 times, most recently from 3e73f61 to a3d79e9 Compare December 19, 2024 10:01
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/stablehlo_reverse_op branch from a3d79e9 to 40f60e4 Compare December 19, 2024 12:35
@kmitrovicTT kmitrovicTT merged commit 8f326f4 into main Dec 19, 2024
21 checks passed
@kmitrovicTT kmitrovicTT deleted the kmitrovic/stablehlo_reverse_op branch December 19, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ops] Add support for TTIR reverse op
5 participants