-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TTIR Reverse op and stablehlo -> ttir conversion #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmitrovicTT
requested review from
sdjordjevicTT,
nsmithtt,
rpavlovicTT,
svuckovicTT,
mtopalovicTT,
mrakitaTT,
nobradovictt and
jserbedzijaTT
as code owners
November 20, 2024 15:27
LPanosTT
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a comment about the verifier for ttir.reverse
kmitrovicTT
force-pushed
the
kmitrovic/stablehlo_reverse_op
branch
2 times, most recently
from
November 20, 2024 16:02
c384c71
to
012512b
Compare
kmitrovicTT
commented
Nov 21, 2024
svuckovicTT
reviewed
Nov 21, 2024
LPanosTT
approved these changes
Nov 21, 2024
Closed
kmitrovicTT
force-pushed
the
kmitrovic/stablehlo_reverse_op
branch
from
December 11, 2024 18:31
9d082ee
to
dade87c
Compare
kmitrovicTT
force-pushed
the
kmitrovic/stablehlo_reverse_op
branch
2 times, most recently
from
December 11, 2024 18:38
6fd8c46
to
4afadf1
Compare
mrakitaTT
approved these changes
Dec 11, 2024
mrakitaTT
approved these changes
Dec 11, 2024
sdjordjevicTT
approved these changes
Dec 17, 2024
kmitrovicTT
force-pushed
the
kmitrovic/stablehlo_reverse_op
branch
from
December 19, 2024 09:17
4afadf1
to
12741bf
Compare
kmitrovicTT
force-pushed
the
kmitrovic/stablehlo_reverse_op
branch
2 times, most recently
from
December 19, 2024 10:01
3e73f61
to
a3d79e9
Compare
kmitrovicTT
force-pushed
the
kmitrovic/stablehlo_reverse_op
branch
from
December 19, 2024 12:35
a3d79e9
to
40f60e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1330.
A part of the solution for for #1142 (need to add tt-torch and tt-xla tests in separate PRs) .
Not implemented end to end since this OP should not exists e2e but rather fitted inside transposed conv op.