Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTNN Rendering Support in TT-Explorer #1298

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Conversation

vprajapati-tt
Copy link
Contributor

  • Added AttrHandler and OpHandler for a more "scaleable" way to render TTMLIR modules in explorer
  • A few bindings updates

@vprajapati-tt vprajapati-tt marked this pull request as ready for review November 18, 2024 17:04
Copy link
Contributor

@odjuricicTT odjuricicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Left a few comments.

Can you also add a TTNN parse test?

tools/explorer/CMakeLists.txt Outdated Show resolved Hide resolved
tools/explorer/tt_adapter/src/tt_adapter/mlir.py Outdated Show resolved Hide resolved
tools/explorer/tt_adapter/src/tt_adapter/mlir.py Outdated Show resolved Hide resolved
tools/explorer/tt_adapter/src/tt_adapter/mlir.py Outdated Show resolved Hide resolved
tools/explorer/tt_adapter/src/tt_adapter/mlir.py Outdated Show resolved Hide resolved
tools/explorer/tt_adapter/src/tt_adapter/mlir.py Outdated Show resolved Hide resolved
@vprajapati-tt
Copy link
Contributor Author

vprajapati-tt commented Nov 19, 2024

Can you also add a TTNN parse test?

Yeah of course! I'll add some in :)

@odjuricicTT
Copy link
Contributor

@vprajapati-tt As discussed offline, you can also delete ttir.py file as it is not used anymore.

Copy link
Contributor

@odjuricicTT odjuricicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vprajapati-tt vprajapati-tt merged commit 02df31c into main Nov 25, 2024
18 checks passed
@vprajapati-tt vprajapati-tt deleted the vprajapati/issue-933 branch November 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants