Matmul1DProgramConfig workaround removal #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azecevicTT
requested review from
tapspatel,
nsmithtt,
jnie-TT,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
tapspatel
approved these changes
Nov 13, 2024
azecevicTT
force-pushed
the
azecevic/matmul-program-config-workaraound-remove
branch
from
697653b to
b2c0315
Compare
jnie-TT
approved these changes
Nov 13, 2024
Merged
Workaround introduced in #894 is not needed anymore. The issue was fixed in metal tenstorrent/tt-metal#13819. Closes #891 FYI @odjuricicTT
azecevicTT
force-pushed
the
azecevic/matmul-program-config-workaraound-remove
branch
from
b2c0315 to
a000cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround introduced in #894 is not needed anymore. The issue was fixed in metal tenstorrent/tt-metal#13819.
Closes #891
FYI @odjuricicTT