ttnn ops backend metal wrapper lib #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbezuljTT
force-pushed
the
mbezulj/2410-ttnnopsbackend-metal-wrapper-lib
branch
2 times, most recently
from
467b4b7 to
c5b33f2
Compare
nsmithtt
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Hey @mbezuljTT, these changes look great! Some comments inline
mbezuljTT
force-pushed
the
mbezulj/2410-ttnnopsbackend-metal-wrapper-lib
branch
2 times, most recently
from
eeb084a to
6577759
Compare
nsmithtt
approved these changes
Nov 14, 2024
mbezuljTT
force-pushed
the
mbezulj/2410-ttnnopsbackend-metal-wrapper-lib
branch
3 times, most recently
from
bbc53b4 to
0634367
Compare
mbezuljTT
requested review from
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
rpavlovicTT,
nobradovictt,
jserbedzijaTT,
jnie-TT,
vmilosevic and
tapspatel
as code owners
svuckovicTT
reviewed
Nov 25, 2024
jnie-TT
reviewed
Nov 26, 2024
mbezuljTT
force-pushed
the
mbezulj/2410-ttnnopsbackend-metal-wrapper-lib
branch
from
fddfb02 to
8bc11da
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mbezuljTT
force-pushed
the
mbezulj/2410-ttnnopsbackend-metal-wrapper-lib
branch
from
8bc11da to
6cba062
Compare
mbezuljTT
force-pushed
the
mbezulj/2410-ttnnopsbackend-metal-wrapper-lib
branch
2 times, most recently
from
217998a to
d1d1019
Compare
vmilosevic
approved these changes
Nov 26, 2024
mbezuljTT
force-pushed
the
mbezulj/2410-ttnnopsbackend-metal-wrapper-lib
branch
from
e17d8c8 to
4028b7b
Compare
nobradovictt
approved these changes
Nov 28, 2024
|
Addressed all comments, merging this PR. afterthoughts are OK, please reach out; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TTNNOpModelLib is to be used for op model interface (constraints, l1, perf)
TTNNOpModelLib is static library that allows us to call ttnn and tt-metal API from mlir TTNN Dialect to enable direct calls to compiler ops API to query for arguments validity, L1 usage, and performance.
The specifics are LLVM/MLIR have exceptions disabled and are built with C++ 17.
Metal is built with exceptions and with C++ 20.
As we are building MLIR and metal using same compiler version, we shouldnt get any ABI issues.
Exceptions would be handled within TTNNWrapperLib.
Added
TTMLIR_ENABLE_OPMODELto be used for this specific build, build has been added to CI. No tests are added, as we add MNIST ops, we shall add MNIST optimizer test. We shall agree when to make this mode enabled by default.@nsmithtt @nobradovictt @sdjordjevicTT I think this should be good initial version
@vmilosevic please take a look at CI changes,