New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#0: Remove set/get queue mode methods #17108

Draft

omilyutin-tt wants to merge 1 commit into main from omilyutin/lf

Contributor

omilyutin-tt commented Jan 25, 2025

Ticket

N/A

Problem description

IDevice exposes get/set methods for "mode" of the underlying executor queue. This is a low level implementation detail that sets locking scheme inside of the queue.

What's changed

Remove the APIs and unconditionally use a lock for the executor queue.

Checklist

Post commit CI passes
Blackhole Post commit (if applicable)
Model regression CI testing passes (if applicable)
Device performance regression CI testing passes (if applicable)
(For models and ops writers) Full new models tests passes
New/Existing tests provide coverage for changes


          Remove set/get queue mode methods

44e910f

Reviewers

ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt will be requested when the pull request is marked ready for review ayerofieiev-tt is a code owner

dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt will be requested when the pull request is marked ready for review dmakoviichuk-tt is a code owner

rfurko-tt Awaiting requested review from rfurko-tt rfurko-tt will be requested when the pull request is marked ready for review rfurko-tt is a code owner

cfjchu Awaiting requested review from cfjchu cfjchu will be requested when the pull request is marked ready for review cfjchu is a code owner

TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu will be requested when the pull request is marked ready for review TT-BrianLiu is a code owner

razorback3 Awaiting requested review from razorback3 razorback3 will be requested when the pull request is marked ready for review razorback3 is a code owner

dongjin-na Awaiting requested review from dongjin-na dongjin-na will be requested when the pull request is marked ready for review dongjin-na is a code owner

bbradelTT Awaiting requested review from bbradelTT bbradelTT will be requested when the pull request is marked ready for review bbradelTT is a code owner

aliuTT Awaiting requested review from aliuTT aliuTT will be requested when the pull request is marked ready for review aliuTT is a code owner

tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal will be requested when the pull request is marked ready for review tt-asaigal is a code owner

abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt will be requested when the pull request is marked ready for review abhullar-tt is a code owner