#14099: ttnn.clip, clamp interface to follow Pytorch #14127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirdhatchaniKN
force-pushed
the
virdhatchani/clip_update
branch
from
95f6532 to
f63677f
Compare
VirdhatchaniKN
changed the title
Aswinmcw
reviewed
Oct 23, 2024
| @@ -1288,7 +1288,7 @@ def clip( | |||
| **kwargs, | |||
| ): | |||
| t0 = setup_tt_tensor(x, device, layout[0], input_mem_config[0], dtype[0]) | |||
| t1 = ttnn.clip(t0, min=low, max=high, memory_config=output_mem_config) | |||
| t1 = ttnn.clip(t0, low, high, memory_config=output_mem_config) | |||
There was a problem hiding this comment.
What happens if I give (t0, high, low)?
umadevimcw
approved these changes
Oct 23, 2024
VirdhatchaniKN
requested review from
patrickroberts and
yan-zaretskiy
as code owners
VirdhatchaniKN
force-pushed
the
virdhatchani/clip_update
branch
from
6fc5827 to
fd1de38
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/clip_update
branch
from
fd1de38 to
4da329f
Compare
ct-clmsn
pushed a commit
to ct-clmsn/tt-metal
that referenced
this pull request
Nov 12, 2024
…torrent#14127) tenstorrent#14099: ttnn.clip interface to follow Pytorch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tenstorrent/tt-metal/actions/runs/11474694921 - passed
Work done : To change the float values to positional arguments as requested in #14099