Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: update documentation and asserts #14101

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

KalaivaniMCW
Copy link
Contributor

@KalaivaniMCW KalaivaniMCW commented Oct 22, 2024

Ticket

Link to Github Issue

#13927
#13928
#10160
#10141
#10081
#9985
#13683
#13854
#13855

Problem description

Updates documentation and add asserts as necessary.
has fixes for the above mentioned issues

What's changed

Added unit tests and updated Doc
Tested assert for proper fail msg

Doc:
Screenshot 2024-10-23 at 11 16 42 AM

Screenshot 2024-10-23 at 11 17 25 AM

Checklist

@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/doc_layout_update branch from 7a7804b to 192f76b Compare October 22, 2024 21:56
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/doc_layout_update branch from 192f76b to 6ca4e28 Compare October 22, 2024 22:20
Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KalaivaniMCW KalaivaniMCW marked this pull request as ready for review October 23, 2024 04:39
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/doc_layout_update branch from ecaa212 to 261c3cc Compare October 24, 2024 09:30
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/doc_layout_update branch from 261c3cc to 7e6aa07 Compare October 24, 2024 13:32
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/doc_layout_update branch from 7e6aa07 to 2efcd6a Compare October 24, 2024 14:20
@KalaivaniMCW KalaivaniMCW merged commit 470fc8d into main Oct 24, 2024
7 checks passed
@KalaivaniMCW KalaivaniMCW deleted the kalaivani/doc_layout_update branch October 24, 2024 14:22
ct-clmsn pushed a commit to ct-clmsn/tt-metal that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants