#11084: Update ternary bw docs #11087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,7 @@ namespace ternary_backward { | |||
| namespace detail { | |||
|
|
|||
| template <typename ternary_backward_operation_t> | |||
| void bind_ternary_backward(py::module& module, const ternary_backward_operation_t& operation, const std::string& description) { | |||
| void bind_ternary_backward(py::module& module, const ternary_backward_operation_t& operation, const std::string& description, const std::string& supported_dtype) { | |||
There was a problem hiding this comment.
Please change all the
const std::string& description, const std::string& supported_dtypeto
std::string_view description, std::string_view supported_dtype
eyonland
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Approving based under assumption you will update based on @patrickroberts
VirdhatchaniKN
force-pushed
the
virdhatchani/ternary_doc
branch
2 times, most recently
from
7affacb to
a67cccb
Compare
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
patrickroberts
approved these changes
Aug 6, 2024
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
temporarily deployed
to
production
GitHub Actions
Inactive
VirdhatchaniKN
force-pushed
the
virdhatchani/ternary_doc
branch
from
297d892 to
d83421d
Compare
VirdhatchaniKN
requested review from
umadevimcw,
ruthreshx,
bharane-ab,
Aswinmcw,
KalaivaniMCW,
mouliraj-mcw and
mcw-anasuya
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Issue : #10585, Issue : #11084
https://github.com/tenstorrent/tt-metal/actions/runs/10266847620 - passed