Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTNN mish - incomplete documentation #8156

Closed
Tracked by #13795
npetrovic-tenstorrent opened this issue May 5, 2024 · 4 comments
Closed
Tracked by #13795

TTNN mish - incomplete documentation #8156

npetrovic-tenstorrent opened this issue May 5, 2024 · 4 comments
Assignees
@mcw-anasuya
Labels
bug Something isn't working op_cat: eltwise

Comments

@npetrovic-tenstorrent
Copy link
Contributor

For TTNN mish op:
The documentation does not cover supported data types (BFLOAT16/BFLOAT8_B) neither the supported layouts (ROW_MAJOR/TILE). In practice, its seems that it does not support BFLOAT8_B type (only BFLOAT16 works), neither layout ROW_MAJOR is supported (TILE supported).
@npetrovic-tenstorrent npetrovic-tenstorrent added bug Something isn't working op_cat: eltwise labels May 5, 2024
@KalaivaniMCW
Copy link
Contributor

KalaivaniMCW commented May 7, 2024 •
edited
Loading

Fix provided in #8050

@KalaivaniMCW KalaivaniMCW self-assigned this May 9, 2024
@umadevimcw
Copy link
Contributor

#7711 (comment)

@KalaivaniMCW
Copy link
Contributor

will be revisited after TTNN migration.

@eyonland eyonland assigned umadevimcw and unassigned KalaivaniMCW Jul 30, 2024
@ruthreshx ruthreshx assigned ruthreshx and unassigned umadevimcw Sep 26, 2024
@eyonland eyonland assigned mcw-anasuya and unassigned ruthreshx Sep 30, 2024
@eyonland eyonland mentioned this issue Oct 15, 2024
Open
mcw-anasuya added a commit that referenced this issue Oct 21, 2024
@mcw-anasuya
#8156: Update documentation and sweep config for mish
c955ef4
@mcw-anasuya mcw-anasuya mentioned this issue Oct 21, 2024
Closed
2 tasks
mcw-anasuya added a commit that referenced this issue Oct 21, 2024
@mcw-anasuya
#8156: Add golden function
abc0790
mcw-anasuya added a commit that referenced this issue Oct 22, 2024
@mcw-anasuya
#8156: Update documentation and sweep config for mish
b1892c0
mcw-anasuya added a commit that referenced this issue Oct 22, 2024
@mcw-anasuya
#8156: Add golden function
52f706f
mcw-anasuya added a commit that referenced this issue Oct 22, 2024
@mcw-anasuya
#8156: Add golden function
8712c8a
mcw-anasuya added a commit that referenced this issue Oct 22, 2024
@mcw-anasuya
#8156: Update documentation and sweep config for mish
b4dd384
mcw-anasuya added a commit that referenced this issue Oct 22, 2024
@mcw-anasuya
#8156: Add golden function
3a5ddb1
mcw-anasuya added a commit that referenced this issue Oct 22, 2024
@mcw-anasuya
#8156: Update documentation and sweep config for mish
c0b1618
mcw-anasuya added a commit that referenced this issue Oct 22, 2024
@mcw-anasuya
#8156: Add golden function
dcdee9e
mcw-anasuya added a commit that referenced this issue Oct 25, 2024
@mcw-anasuya
#8156: Update documentation and sweep config for mish
1c01f0b
mcw-anasuya added a commit that referenced this issue Oct 25, 2024
@mcw-anasuya
#8156: Add golden function
4839eb8
mcw-anasuya added a commit that referenced this issue Oct 28, 2024
@mcw-anasuya
#8156: Update documentation and sweep config for mish
3bdfd9d
mcw-anasuya added a commit that referenced this issue Oct 28, 2024
@mcw-anasuya
#8156: Add golden function
1f7e903
mcw-anasuya added a commit that referenced this issue Oct 28, 2024
@mcw-anasuya
#8156: Update documentation and sweep config for mish
057c23c
mcw-anasuya added a commit that referenced this issue Oct 28, 2024
@mcw-anasuya
#8156: Add golden function
1f8937a
mcw-anasuya added a commit that referenced this issue Oct 29, 2024
@mcw-anasuya @VirdhatchaniKN
#8156: Update documentation and sweep config for mish
e83a753
mcw-anasuya added a commit that referenced this issue Oct 29, 2024
@mcw-anasuya @VirdhatchaniKN
#8156: Add golden function
05674e4
mcw-anasuya added a commit that referenced this issue Oct 29, 2024
@mcw-anasuya @VirdhatchaniKN
#8156: Add golden function
02f5dde
mcw-anasuya added a commit that referenced this issue Oct 29, 2024
@mcw-anasuya @VirdhatchaniKN
#8156: Update documentation and sweep config for mish
2709053
mcw-anasuya added a commit that referenced this issue Oct 29, 2024
@mcw-anasuya @VirdhatchaniKN
#8156: Add golden function
53204bf
@mcw-anasuya mcw-anasuya mentioned this issue Oct 30, 2024
Merged
8 tasks
@mcw-anasuya
Copy link
Contributor

Added supported datatypes and layouts and merged to main.
Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcw-anasuya mcw-anasuya

Labels
bug Something isn't working op_cat: eltwise
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@umadevimcw @ruthreshx @npetrovic-tenstorrent @KalaivaniMCW @mcw-anasuya