-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] Ttnn::multiply does not broadcast in second dimension #13646
Labels
Comments
dmakoviichuk-tt
changed the title
[Bug Report] Ttnn::multiply do not broadcast in second dimension.
[Bug Report] Ttnn::multiply does not broadcast in second dimension
Oct 9, 2024
Are you able to use ttnn.bcast here instead as a workaround? |
umadevimcw
added a commit
that referenced
this issue
Oct 10, 2024
1 task
@dmakoviichuk-tt @eyonland #13673 The above PR holds functionality support for broadcasting the second dimension using repeat. This will affect the performance as we are using the repeat op but we can use it now for functionality and update this later once broadcast support is updated |
umadevimcw
added a commit
that referenced
this issue
Oct 10, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 14, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 14, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 16, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 16, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 16, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 16, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 16, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 16, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 21, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 21, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 21, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 22, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 22, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 22, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
umadevimcw
added a commit
that referenced
this issue
Oct 25, 2024
PR is merged to main. Hence closing this issue |
ct-clmsn
pushed a commit
to ct-clmsn/tt-metal
that referenced
this issue
Nov 12, 2024
* tenstorrent#13646: Add second dimension support in binary op * tenstorrent#13646: Add unit test for channel bcast using repeat * tenstorrent#13646: Add assert statement * tenstorrent#13646: Fix CI failure issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Ttnn::multiply do not broadcast in second dimension.
Fails silently by throwing near NaN/Inf valuesTo Reproduce
Steps to reproduce the behavior:
It will print a garbage.
Expected behavior
it should work.
Additional context
Currently it requires us to generate broadcasted vectors on cpu.
It is a huge problem for a training performance.
@eyonland if you don't think you can fix it please let me know I'll find another owner.
The text was updated successfully, but these errors were encountered: