-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Values in (2^15, 2^23) are not rounded by rounding ops #13544
Comments
Hi @jdh8 Hi @rdjogoTT, @rtawfik01 cc: @eyonland |
@mouliraj-mcw I do not believe support for float-to-int32 is going to become available as a single call similar to |
### Ticket Link to Github Issue #13544 ### Problem description - Floor op ignore values outside range of i16 ### What's changed - Updated the logic to support fp32 ### Profiling Results : Shape used [1, 1, 102400, 32] Kernel Duration [ns] - Bfloat16 : 68870 - Float32 : 156560 ### Checklist - [x] All Post commit CI
Currently, rounding ops ignore values outside range of
i16
, i.e. [-215, 215).tt-metal/tt_metal/hw/ckernels/wormhole_b0/metal/llk_api/llk_sfpu/ckernel_sfpu_floor.h
Lines 31 to 33 in 3d33e8d
Since there are 24 significand bits (23 explicit) in
f32
, the maximum finite non-integer inf32
is 223 − 0.5. As a result, non-integers with absolute value in (215, 223) are returned as is and not rounded.Either of the following would solve this issue:
i32
instead ofi16
The text was updated successfully, but these errors were encountered: