Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer support of eltwise ops #13374

Open
Tracked by #13795
, #14077
...
eyonland opened this issue Oct 2, 2024 · 2 comments
Open
Tracked by #13795
, #14077
...

Integer support of eltwise ops #13374

eyonland opened this issue Oct 2, 2024 · 2 comments
Assignees
@mouliraj-mcw
Labels
MCW op_cat: eltwise

Comments

@eyonland
Copy link
Contributor

eyonland commented Oct 2, 2024 •
edited by mouliraj-mcw
Loading

The following list of element-wise ops require output integer numbers.

Completed:

ELEMWISE_UNARY_EQ
ELEMWISE_UNARY_GE
ELEMWISE_UNARY_GT
ELEMWISE_UNARY_LE
ELEMWISE_UNARY_LT
ELEMWISE_UNARY_NE
ELEMWISE_UNARY_LOGICALNOT
ELEMWISE_BINARY_GE
ELEMWISE_BINARY_GT
ELEMWISE_BINARY_EQ
ELEMWISE_BINARY_LE
ELEMWISE_BINARY_LOGICALAND
ELEMWISE_BINARY_LOGICALOR
ELEMWISE_BINARY_LOGICALXOR
ELEMWISE_BINARY_LT
ELEMWISE_BINARY_NE

Yet To Add:

ELEMWISE_UNARY_SIGNBIT
ELEMWISE_UNARY_ISFINITE
ELEMWISE_UNARY_ISINF
ELEMWISE_UNARY_ISNAN
ELEMWISE_UNARY_ISNEGINF
ELEMWISE_UNARY_ISPOSINF
ELEMWISE_BINARY_ISCLOSE
ELEMWISE_BINARY_ISCLOSENAN
@eyonland eyonland mentioned this issue Oct 15, 2024
Open
@KalaivaniMCW
Copy link
Contributor

KalaivaniMCW commented Nov 4, 2024 •
edited
Loading

Some of the ops listed here are blocked by #14077
ELEMWISE_UNARY_ISFINITE
ELEMWISE_UNARY_ISINF
ELEMWISE_UNARY_ISNAN
ELEMWISE_UNARY_ISNEGINF
ELEMWISE_UNARY_ISPOSINF
ELEMWISE_UNARY_SIGNBIT
ELEMWISE_BINARY_ISCLOSE
ELEMWISE_BINARY_ISCLOSENAN

mouliraj-mcw added a commit that referenced this issue Nov 11, 2024
@mouliraj-mcw
#13374: Add integer support for eltwise ops
bf72d05
@mouliraj-mcw mouliraj-mcw mentioned this issue Nov 12, 2024
Merged
1 task
mouliraj-mcw added a commit that referenced this issue Nov 17, 2024
@mouliraj-mcw
Add integer support for eltwise ops (#14953)
7a99cc8 
### Ticket
Link to Github Issue #13374

### What's changed

-  Updated the comparison ops to return datatype as integer.


Ops Added Int Support:

- ELEMWISE_UNARY_EQ
- ELEMWISE_UNARY_GE
- ELEMWISE_UNARY_GT
- ELEMWISE_UNARY_LE
- ELEMWISE_UNARY_LT
- ELEMWISE_UNARY_NE
- ELEMWISE_BINARY_GE
- ELEMWISE_BINARY_GT
- ELEMWISE_BINARY_EQ
- ELEMWISE_BINARY_LE
- ELEMWISE_BINARY_LOGICALAND
- ELEMWISE_BINARY_LOGICALOR
- ELEMWISE_BINARY_LOGICALXOR
- ELEMWISE_BINARY_LT
- ELEMWISE_BINARY_NE

### Checklist
- [ ] [All Post commit
CI](https://github.com/tenstorrent/tt-metal/actions/runs/11796923243)
@KalaivaniMCW
Copy link
Contributor

Moving this to On-Hold until #14077 is resolved

@eyonland eyonland mentioned this issue Dec 19, 2024
Open
9 tasks
@eyonland eyonland added the MCW label Dec 20, 2024
@KalaivaniMCW KalaivaniMCW mentioned this issue Dec 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mouliraj-mcw mouliraj-mcw

Labels
MCW op_cat: eltwise
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eyonland @KalaivaniMCW @mouliraj-mcw